From b4bf550863f8b1ee6da8623384875c943b659990 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=20Tr=C3=B6ger?= Date: Sun, 15 Feb 2026 18:49:29 +0100 Subject: [PATCH] fix: closing some issues from sonarqube --- Backend/endpoints/pdf-create.go | 2 +- Backend/endpoints/time.go | 7 ------- Backend/helper/logs/main.go | 4 ++-- Backend/models/compoundDay.go | 4 +--- 4 files changed, 4 insertions(+), 13 deletions(-) diff --git a/Backend/endpoints/pdf-create.go b/Backend/endpoints/pdf-create.go index 6682409..b680a16 100644 --- a/Backend/endpoints/pdf-create.go +++ b/Backend/endpoints/pdf-create.go @@ -21,7 +21,7 @@ import ( const DE_DATE string = "02.01.2006" const FILE_YEAR_MONTH string = "2006_01" -var PDF_DIRECTORY = helper.GetEnv("PDF_PATH", "/doc/") // TODO +var PDF_DIRECTORY = helper.GetEnv("PDF_PATH", "/doc/") func PDFCreateController(w http.ResponseWriter, r *http.Request) { helper.RequiresLogin(Session, w, r) diff --git a/Backend/endpoints/time.go b/Backend/endpoints/time.go index 883c7b3..227fb5f 100644 --- a/Backend/endpoints/time.go +++ b/Backend/endpoints/time.go @@ -257,12 +257,6 @@ func updateAbsence(r *http.Request) error { log.Println("Cannot get Absence for id: ", absenceId, err) return err } - if r.FormValue("action") == "delete" { - log.Println("Deleting Absence!", "Not implemented") - // TODO - //absence.Delete() - return nil - } if absence.Update(newAbsence) { err = absence.Save() @@ -272,5 +266,4 @@ func updateAbsence(r *http.Request) error { } } return nil - } diff --git a/Backend/helper/logs/main.go b/Backend/helper/logs/main.go index 7744bf7..7afb6fd 100644 --- a/Backend/helper/logs/main.go +++ b/Backend/helper/logs/main.go @@ -17,8 +17,8 @@ type FileLog struct { var Logs map[string]FileLog = make(map[string]FileLog) func NewAudit() (i *log.Logger, close func() error) { - LOG_FILE := "logs/" + time.Now().Format(time.DateOnly) + ".log" - logFile, err := os.OpenFile(LOG_FILE, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0644) + logName := "logs/" + time.Now().Format(time.DateOnly) + ".log" + logFile, err := os.OpenFile(logName, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0644) if err != nil { log.Panic(err) } diff --git a/Backend/models/compoundDay.go b/Backend/models/compoundDay.go index c3aac27..dd89665 100644 --- a/Backend/models/compoundDay.go +++ b/Backend/models/compoundDay.go @@ -21,9 +21,7 @@ type CompoundDay struct { func (c *CompoundDay) IsSubmittedAndAccepted() bool { var isSubmittedAndAccepted = true for _, day := range c.DayParts { - _isSubmittedAndAccepted := day.IsSubmittedAndAccepted() - isSubmittedAndAccepted = isSubmittedAndAccepted && _isSubmittedAndAccepted - slog.Info("Result from IsSubmittedCheck", "Result", _isSubmittedAndAccepted, "compount", day.ToString()) + isSubmittedAndAccepted = isSubmittedAndAccepted && day.IsSubmittedAndAccepted() } return isSubmittedAndAccepted }