updated sonarqube + fixed first issues

Backend/static/script.js

@@ -1,5 +1,5 @@
 function clearEditState() {
-  for (e of document.querySelectorAll(".edit")) {
+  for (let e of document.querySelectorAll(".edit")) {
     e.classList.remove("edit");
   }
   toggleAbsenceEdit(false);
@@ -8,11 +8,9 @@ function clearEditState() {
 function editWorkday(element, event, id, isWorkDay) {
   console.log("editWorkday called", isWorkDay);
   event.preventDefault();
-  var form = document.getElementById(id);
+  const form = document.getElementById(id);
   if (form == null) {
-    form = element
-      .closest(".grid-sub")
-      .querySelector(".all-booking-component > form");
+    form = element.closest(".grid-sub").querySelector(".all-booking-component > form");
   }
 
   clearEditState();
@@ -22,37 +20,26 @@ function editWorkday(element, event, id, isWorkDay) {
   if (isWorkDay) {
     element.classList.add("edit");
     if (element.classList.contains("edit")) {
-      form.querySelectorAll("input, select").forEach((input) => {
+      for (let input of form.querySelectorAll("input, select")) {
         input.disabled = false;
-      });
+      }
     } else {
       form.submit();
     }
   } else {
-    var absenceForm = document.getElementById("absence_form");
+    const absenceForm = document.getElementById("absence_form");
 
-    if (id != 0) {
-      syncFields(form, absenceForm, [
-        "date_from",
-        "date_to",
-        "aw_type",
-        "aw_id",
-      ]);
+    if (id == 0) {
+      absenceForm.querySelector("[name=date_from]").value = form.id.replace("time-", "");
+      absenceForm.querySelector("[name=date_to]").value = form.id.replace("time-", "");
     } else {
-      absenceForm.querySelector("[name=date_from]").value = form.id.replace(
-        "time-",
-        "",
-      );
-      absenceForm.querySelector("[name=date_to]").value = form.id.replace(
-        "time-",
-        "",
-      );
+      syncFields(form, absenceForm, ["date_from", "date_to", "aw_type", "aw_id"]);
     }
   }
 }
 
 function toggleAbsenceEdit(state) {
-  var form = document.getElementById("absence_form");
+  const form = document.getElementById("absence_form");
   if (state) {
     form.classList.remove("hidden");
     form.scrollIntoView({
@@ -66,22 +53,22 @@ function toggleAbsenceEdit(state) {
 }
 
 function syncFields(from, to, fieldsToSync) {
-  fieldsToSync.forEach((name) => {
-    const src = from.querySelector(`[name=${name}]`);
-    const target = to.querySelector(`[name=${name}]`);
+  for (let field of fieldsToSync) {
+    const src = from.querySelector(`[name=${field}]`);
+    const target = to.querySelector(`[name=${field}]`);
     if (!src || !target) return;
     target.value = src.value;
-  });
+  }
 }
 
 function navigateWeek(element, event, direction) {
-  var dateInput = element.closest("form").querySelector("input[type=date]");
-  var date = dateInput.valueAsDate;
+  const dateInput = element.closest("form").querySelector("input[type=date]");
+  const date = dateInput.valueAsDate;
   date.setDate(date.getDate() + 7 * direction);
   date.setHours(10);
   dateInput.valueAsDate = date;
 }
 
 function logoutUser() {
-  fetch("/user/logout", {}).then(() => window.location.reload());
+  fetch("/user/logout", {}).then(() => globalThis.location.reload());
 }