closes #14

Backend/endpoints/user-session.go

@@ -1,7 +1,6 @@
 package endpoints
 
 import (
-	"arbeitszeitmessung/helper"
 	"arbeitszeitmessung/models"
 	"arbeitszeitmessung/templates"
 	"context"
@@ -21,42 +20,38 @@ func CreateSessionManager(lifetime time.Duration) *scs.SessionManager {
 	return Session
 }
 
-func showLoginPage(w http.ResponseWriter, r *http.Request, failed bool) {
+func showLoginPage(w http.ResponseWriter, r *http.Request, success bool, errorMsg string) {
 	r = r.WithContext(context.WithValue(r.Context(), "session", Session))
-	if helper.GetEnv("GO_ENV", "production") == "debug" {
-		// http.Redirect(w, r, "/time", http.StatusSeeOther)
-		templates.LoginPage(failed).Render(r.Context(), w)
-	}
 	if Session.Exists(r.Context(), "user") {
 		http.Redirect(w, r, "/time", http.StatusSeeOther)
 	}
-	templates.LoginPage(failed).Render(r.Context(), w)
+	templates.LoginPage(success, errorMsg).Render(r.Context(), w)
 }
 
 func loginUser(w http.ResponseWriter, r *http.Request) {
 	err := r.ParseForm()
 	if err != nil {
 		log.Println("Error parsing form!", err)
-		http.Error(w, "Internal error", http.StatusBadRequest)
+		showLoginPage(w, r, false, "Internal error!")
 		return
 	}
 	_personal_nummer := r.FormValue("personal_nummer")
 	if _personal_nummer == "" {
 		log.Println("No personal_nummer provided!")
-		http.Error(w, "No personal_nummer provided", http.StatusBadRequest)
+		showLoginPage(w, r, false, "Keine Personalnummer gesetzt.")
 		return
 	}
 	personal_nummer, err := strconv.Atoi(_personal_nummer)
 	if err != nil {
 		log.Println("Cannot parse personal nubmer!")
-		http.Error(w, "Cannot parse number", http.StatusBadRequest)
+		showLoginPage(w, r, false, "Personalnummer ist nicht valide gesetzt.")
 		return
 	}
-
 	user, err := models.GetUserByPersonalNr(personal_nummer)
 	if err != nil {
 		log.Println("No user found under this personal number!", err)
-		http.Error(w, "No user found!", http.StatusNotFound)
+		showLoginPage(w, r, false, "Nutzer unter dieser Personalnummer nicht gefunden.")
+		return
 	}
 
 	password := r.FormValue("password")
@@ -65,11 +60,8 @@ func loginUser(w http.ResponseWriter, r *http.Request) {
 		Session.Put(r.Context(), "user", user.PersonalNummer)
 		Session.Commit(r.Context())
 		http.Redirect(w, r, "/time", http.StatusSeeOther) //with this browser always uses GET
-	} else {
-		showLoginPage(w, r, true)
-		return
 	}
-	showLoginPage(w, r, false)
+	showLoginPage(w, r, false, "")
 }
 
 func logoutUser(w http.ResponseWriter, r *http.Request) {

Backend/endpoints/user.go

@@ -19,7 +19,7 @@ func UserHandler(w http.ResponseWriter, r *http.Request) {
 func LoginHandler(w http.ResponseWriter, r *http.Request) {
 	switch r.Method {
 	case http.MethodGet:
-		showLoginPage(w, r, false)
+		showLoginPage(w, r, true, "")
 	case http.MethodPost:
 		loginUser(w, r)
 	default: