fix: closing some issues from sonarqube

Backend/endpoints/pdf-create.go

@@ -21,7 +21,7 @@ import (
 const DE_DATE string = "02.01.2006"
 const FILE_YEAR_MONTH string = "2006_01"
 
-var PDF_DIRECTORY = helper.GetEnv("PDF_PATH", "/doc/") // TODO
+var PDF_DIRECTORY = helper.GetEnv("PDF_PATH", "/doc/")
 
 func PDFCreateController(w http.ResponseWriter, r *http.Request) {
 	helper.RequiresLogin(Session, w, r)

Backend/endpoints/time.go

@@ -257,12 +257,6 @@ func updateAbsence(r *http.Request) error {
 		log.Println("Cannot get Absence for id: ", absenceId, err)
 		return err
 	}
-	if r.FormValue("action") == "delete" {
-		log.Println("Deleting Absence!", "Not implemented")
-		// TODO
-		//absence.Delete()
-		return nil
-	}
 
 	if absence.Update(newAbsence) {
 		err = absence.Save()
@@ -272,5 +266,4 @@ func updateAbsence(r *http.Request) error {
 		}
 	}
 	return nil
-
 }

Backend/helper/logs/main.go

@@ -17,8 +17,8 @@ type FileLog struct {
 var Logs map[string]FileLog = make(map[string]FileLog)
 
 func NewAudit() (i *log.Logger, close func() error) {
-	LOG_FILE := "logs/" + time.Now().Format(time.DateOnly) + ".log"
+	logName := "logs/" + time.Now().Format(time.DateOnly) + ".log"
-	logFile, err := os.OpenFile(LOG_FILE, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0644)
+	logFile, err := os.OpenFile(logName, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0644)
 	if err != nil {
 		log.Panic(err)
 	}

Backend/models/compoundDay.go

@@ -21,9 +21,7 @@ type CompoundDay struct {
 func (c *CompoundDay) IsSubmittedAndAccepted() bool {
 	var isSubmittedAndAccepted = true
 	for _, day := range c.DayParts {
-		_isSubmittedAndAccepted := day.IsSubmittedAndAccepted()
+		isSubmittedAndAccepted = isSubmittedAndAccepted && day.IsSubmittedAndAccepted()
-		isSubmittedAndAccepted = isSubmittedAndAccepted && _isSubmittedAndAccepted
-		slog.Info("Result from IsSubmittedCheck", "Result", _isSubmittedAndAccepted, "compount", day.ToString())
 	}
 	return isSubmittedAndAccepted
 }